Commit 9e75ab0a8ca9cbec66c631a2438062e30d93a515 - Robin

Re-implement < > <= >= to avoid bugs with large numbers. Chris Pressey 5 years ago

2 changed file(s) with 47 addition(s) and 9 deletion(s). Raw diff Collapse all Expand all

-1

HISTORY.md less more

3	3	Robin 0.4 (autumn 2019)
4	4	---------
5	5
6		* Improved modularity of the specification.
	6	* Reworked entire specification document, making it properly modular.
7	7	* Many tests are for the Robin Expression Language, and have been
8	8	made explicitly so, instead of for the Robin Toplevel Language.
9	9	* The `bound?` predicate was added to env lib in stdlib.
10	10	* The `require` top-level form was added.
11	11	* The `write` command was added to the definition of `line-terminal`.
12	12	* Added `random-source` facility to reactors in reference implementation.
	13	* Fixed shortcomings in `<` and `>` when operating on large numbers
	14	would give incorrect results (thanks wob_jonas!)
	15	* Clarified what Robin borrows from PicoLisp (thanks arseniiv!)
13	16
14	17	Robin 0.3 (Aug 2019)
15	18	---------

+43

-8

stdlib/cmp.robin less more

21	21	\| (> (subtract 0 1610612736) 1610612736)
22	22	= #f
23	23
	24	\| (> 2147483646 2147483647)
	25	= #f
	26
	27	\| (> 1 2147483647)
	28	= #f
	29
	30	\| (> (subtract 0 2147483647) (subtract 0 2147483646))
	31	= #f
	32
	33	\| (> (subtract 0 2147483647) (subtract 0 1))
	34	= #f
	35
24	36	`>` expects exactly two arguments, both numbers.
25	37
26		\| (> 14)
	38	\| (> 14)
27	39	? uncaught exception: (illegal-arguments (14))
28	40
29		\| (> 14 23 57)
	41	\| (> 14 23 57)
30	42	? uncaught exception: (illegal-arguments (14 23 57))
31	43
32		\| (> 14 #t)
	44	\| (> 14 #t)
33	45	? uncaught exception: (expected-number #t)
34	46
35		\| (> #t 51)
	47	\| (> #t 51)
36	48	? uncaught exception: (expected-number #t)
37	49
38	50	### `<` ###

53	65	= #f
54	66
55	67	\| (< (subtract 0 1610612736) 1610612736)
	68	= #t
	69
	70	\| (< 2147483646 2147483647)
	71	= #t
	72
	73	\| (< 1 2147483647)
	74	= #t
	75
	76	\| (< (subtract 0 2147483647) (subtract 0 2147483646))
	77	= #t
	78
	79	\| (< (subtract 0 2147483647) (subtract 0 1))
56	80	= #t
57	81
58	82	`<` expects exactly two arguments, both numbers.

141	165
142	166	(define > (macro (self args env)
143	167	(bind-args (a b) args env
144		(equal? (sign (subtract a b)) 1))))
	168	(if (equal? (list (sign a) (sign b)) (list (subtract 0 1) 1))
	169	#f
	170	(if (equal? (list (sign a) (sign b)) (list 1 (subtract 0 1)))
	171	#t
	172	(equal? (sign (subtract a b)) 1))))))
	173
145	174	(define >= (macro (self args env)
146	175	(bind-args (a b) args env
147		(if (equal? a b) #t (equal? (sign (subtract a b)) 1)))))
	176	(if (equal? a b) #t (> a b)))))
	177
148	178	(define < (macro (self args env)
149	179	(bind-args (a b) args env
150		(equal? (sign (subtract a b)) (subtract 0 1)))))
	180	(if (equal? (list (sign a) (sign b)) (list (subtract 0 1) 1))
	181	#t
	182	(if (equal? (list (sign a) (sign b)) (list 1 (subtract 0 1)))
	183	#f
	184	(equal? (sign (subtract a b)) (subtract 0 1)))))))
	185
151	186	(define <= (macro (self args env)
152	187	(bind-args (a b) args env
153		(if (equal? a b) #t (equal? (sign (subtract a b)) (subtract 0 1))))))
	188	(if (equal? a b) #t (< a b)))))